[Wf-Diagnostics] Refactor the workflow diagnostics initialisation code #6595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
dkrotx
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Invariants are initialised outside the service and provided as inputs before starting worker service or diagnostics. As a result, the diagnostics workflow is generic and performs the same checks and rootcause across all invariants
Why?
The invariants used in workflow diagnostics were initialised within the service and as a result was hard to setup overrides for alternative implementations of the same invariant
How did you test it?
Unit tests
Potential risks
Invariant interface has been modified so when this PR is merged with alternate implementations within Uber, they need to be modified accordingly
Release notes
Documentation Changes