[Wf-Diagnostics] retrieve workflow execution history within issue identification activity #6607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntification activity
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
approved these changes
Jan 10, 2025
3vilhamster
reviewed
Jan 10, 2025
| } | ||
|
|
||
| func (w *dw) retrieveExecutionHistory(ctx context.Context, info retrieveExecutionHistoryInputParams) (*types.GetWorkflowExecutionHistoryResponse, error) { |
There was a problem hiding this comment.
The downside of this change is that you will have to download history multiple times for all diagnostics. If performance considerations arise, we might need to work on an external storage option to pull it from the DB once and then only download it from the storage (which should be faster).
There was a problem hiding this comment.
All issue checks are done after the history retrieval so its ok with the current req but I do agree that if we have to share it amongst other modules we need ext storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
workflow execution history was retrieved in a separate activity and now is moved under the issue identification activity in diagnostics workflow
Why?
for long running workflows, the result will be too large to be passed within activities
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes