Use Cassandra's ttl to populate Expiry field in persistence.TaskInfo #6624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fimanishi
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
approved these changes
Jan 15, 2025
taylanisikdemir
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Populate Expiry field in persistence.TaskInfo in matching for cassandra implementation using cassandra's TTL for the task column. Previously the field was not populated in nosql implementations. If there is no TTL, use time.Time zero value time.Time{}.
Why?
Expiry is used in an edge case when the task can't be mark as completed. It also will be used by the task completer to determine if the task has expired before retrying to check if it has started
How did you test it?
Unit test and tested on a local server
Potential risks
If the parsing of the ttl value from cassandra is wrong, it could break async task processing. Must validate in staging.
Release notes
Implement persistence.TaskInfo expiry support for Cassandra by utilizing the TTL value of the row's task.
Documentation Changes