Update redispatcher to respect task redispatch time #6639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
force-pushed
the
redispatcher
branch
from
2f42f12 to
988c81d
Compare
| @@ -261,44 +253,21 @@ func (r *redispatcherImpl) redispatchTasks(notification redispatchNotification) | |||
| totalRedispatched++ | |||
| } | |||
| } | |||
| if !pq.IsEmpty() { | |||
| item, _ := pq.Peek() | |||
| r.timerGate.Update(item.redispatchTime) | |||
There was a problem hiding this comment.
Check if Peek() returned error. item might be nil
There was a problem hiding this comment.
Peek never returns error if it's not empty.
Maybe I can introduce a new method MustPeek, which is only used on non-empty queue
taylanisikdemir
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Redispatcher previously was triggered periodically in the background and send all the tasks that should be redispatched before now to the task scheduler. This creates 2 issues:
How did you test it?
unit tests
Potential risks
Redispatcher not working
Release notes
Documentation Changes