Skip to content

Revert "Add SQLite plugin (#6643)" #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

Revert "Add SQLite plugin (#6643)" #6670

merged 1 commit into from
Feb 13, 2025

Conversation

shijiesheng
Copy link
Member

This reverts commit 30e5c77.

What changed?

#6643

Why?

Internally we use a lower version of indirect dependency. tetratelabs/wazero@v1.1.0...v1.8.2
And this indirect dependency is actually used by an incident mitigation tooling. So it's safer to keep the lower version.

However, using the lower version doesn't build because of go-sqlite3 library we used

% make build                                         
Building all packages and submodules...
# github.com/ncruces/go-sqlite3/internal/alloc
../../../go/pkg/mod/github.com/ncruces/[email protected]/internal/alloc/alloc_unix.go:12:44: undefined: experimental.LinearMemory
make: *** [build] Error 1

How did you test it?

unit test

Potential risks

Release notes

Documentation Changes

@shijiesheng shijiesheng merged commit e36c818 into cadence-workflow:master Feb 13, 2025
22 checks passed
arzonus added a commit to arzonus/cadence that referenced this pull request Feb 25, 2025
@arzonus
Reapply "Add SQLite plugin (cadence-workflow#6643)" (cadence-workflow…
958020e 
…#6670)

This reverts commit e36c818.
arzonus added a commit to arzonus/cadence that referenced this pull request Feb 25, 2025
@arzonus
Reapply "Add SQLite plugin (cadence-workflow#6643)" (cadence-workflow…
31151e3 
…#6670)

This reverts commit e36c818.
@arzonus arzonus mentioned this pull request Feb 26, 2025
Merged
1 task
arzonus added a commit that referenced this pull request Mar 5, 2025
@arzonus
Add SQLite plugin (#6689)
cdc6b2c 
* Reapply "Add SQLite plugin (#6643)" (#6670)

This reverts commit e36c818.

* support github.com/ncruces/go-sqlite3 args

* make pr

* fix tests

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shijiesheng @taylanisikdemir