Validate TaskList partition updates via CLI are safe #6682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| return fmt.Errorf("DescribeTaskList failed: %w", err) | ||
| } | ||
| if len(description.Pollers) == 0 { | ||
| return fmt.Errorf("'%s' has no pollers of type '%s'", tl.Name, tlt.String()) |
There was a problem hiding this comment.
I wonder if this check should be just warning or move it to the end. Operator seeing this error might just rerun with -f without knowing about the dangerous stuff checked below.
There was a problem hiding this comment.
Good call out, I'm going to move this check to the end
taylanisikdemir
approved these changes
Feb 20, 2025
Add additional validation to confirm that the proposed update is safe. Provide a "force" flag to skip this additional validation. This covers three main potential errors: - Prevent updating the wrong TaskList by checking whether it has pollers - Prevent removing currently active write partitions as they could have tasks. These have to be removed in a two-step process where they're removed from writing and then from reading. - Prevent removing read partitions that still have tasks. These need to stay as read partitions until pollers have taken all the tasks (or the tasks have timed out).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional validation to confirm that the proposed update is safe. Provide a "force" flag to skip this additional validation.
This covers three main potential errors:
What changed?
admin tasklist upcommand before applying the update.Why?
How did you test it?
Potential risks
Release notes
Documentation Changes