Reprioritize responses of GetReplicationMessagesResponse in history #6710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arzonus
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
arzonus
force-pushed
the
fix-replication-messages-not-fit-in-response-history-handler
branch
from
098c00c to
e0afb98
Compare
…by oldest creationTime of replication messages
arzonus
force-pushed
the
fix-replication-messages-not-fit-in-response-history-handler
branch
from
2331000 to
835c8cd
Compare
dkrotx
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
In case of a shrunk response to the GetReplicationMessages call, the history service will give priority to shard messages with the older creation time of replication tasks.
Why?
The PR continues the changes done in the previous PR #6696.
How did you test it?
Potential risks
Potentially other shards without big replication tasks may experience some bigger delays due to giving prioritization to older shards.
Release notes
Documentation Changes