Refactor: Move constants.go to dedicated constants package #6713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move common/constants.go -> common/constants/constants.go
timl3136
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| @@ -772,11 +773,11 @@ func createVisibilityMessage( | |||
| executionTimeUnixNano int64, | |||
| taskID int64, | |||
| memo []byte, | |||
| encoding common.EncodingType, | |||
| encoding constants.EncodingType, | |||
There was a problem hiding this comment.
No action: comment only:
I think its not great we have a type in that file, but I also understand we need it declared there in order to have constants use it, so
service/history/execution/mutable_state_builder_methods_child_workflow_test.go
Outdated
Show resolved
Hide resolved
service/history/execution/mutable_state_decision_task_manager_test.go
Outdated
Show resolved
Hide resolved
davidporter-id-au
approved these changes
Mar 21, 2025
davidporter-id-au
approved these changes
Mar 21, 2025
|
ping me if you need a stamp once the conflicts are resolved, PRs like this are hard to merge unless you get a fast approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Move common/constants.go -> common/constants/constants.go and refractor relevant code
We also changed some .tmpl files in responding to this change.
Why?
Currently. constants.go does not refer to any additional package since it only contains constant. Therefore, we should move it to it's dedicated package so that we won't be restricted due to dependency cycle.
It also makes imports more semantically clear with constants.SomeConstant vs common.SomeConstant
How did you test it?
Unit tests, it's only refractoring
Potential risks
only code referring to constants.go is changed, any incompatible part will be caught by unit tests.
Release notes
Documentation Changes