Skip to content

Append unauthorized errors in CLI with message to check domain and cluster input #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

sankari165
Copy link
Member

@sankari165 sankari165 commented Mar 12, 2025

What changed?
Error message when user sees request unauthorised error

Why?
when a user request is unauthorised it could occur when the domain doesnt exist but request gets access denied before the domain check

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link
Member

@dkrotx dkrotx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer us doing a request from auth plugin, but maybe we don't have enough context there.
lgtm otherwise.

@sankari165 sankari165 merged commit 792f0f8 into cadence-workflow:master Mar 12, 2025
22 checks passed
@sankari165 sankari165 deleted the CDNC-12473 branch March 12, 2025 15:10
@sankari165
Copy link
Member Author

I would prefer us doing a request from auth plugin, but maybe we don't have enough context there. lgtm otherwise.

  1. all api calls like domain describe will go through auth so it becomes a loop
  2. ability to check if a domain exists is via the history service/domain cache and thats quite down the layer of a user request. we would’nt be able to check from the authorizer (also thats causes mix up of scope)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants