Simplify Isolation Group Determination #6768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The partition package was originally intended to abstract isolation group assignment and deterministically reassign tasks to new isolation groups, but with isolation group leaking being introduced we no longer explicitly move tasks to another isolation group. Additionally, the isolation duration has moved some of this logic from the partition package to the task_list_manager. At this point the partition package has turned into a very complicated solution to the questions "is this isolation group drained" and "are there recent pollers from this isolation group". Delete it, and inline the behavior with the callsite, simplifying both. Additionally remove the never-returned error from the function type to simplify callers.
natemort
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partition package was originally intended to abstract isolation group assignment and deterministically reassign tasks to new isolation groups, but with isolation group leaking being introduced we no longer explicitly move tasks to another isolation group. Additionally, the isolation duration has moved some of this logic from the partition package to the task_list_manager.
At this point the partition package has turned into a very complicated solution to the questions "is this isolation group drained" and "are there recent pollers from this isolation group". Delete it, and inline the behavior with the callsite, simplifying both.
Additionally remove the never-returned error from the function type to simplify callers.
This should be functionally identical, although I've also removed the leak cause for "unknown group". It's ambiguous with "no recent pollers" and I don't think really adds any value.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes