Add task category tag to history tasks metrics #6769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| @@ -143,6 +143,23 @@ func (p *base) call(scope int, op func() error, tags ...metrics.Tag) error { | |||
| return err | |||
| } | |||
|
|
|||
| func (p *base) callWithoutDomainTag(scope int, op func() error, tags ...metrics.Tag) error { | |||
There was a problem hiding this comment.
what about the functions that uses callWithDomainAndShardScope? category will be missing for those
There was a problem hiding this comment.
These history tasks methods don't fall into that branch, because they are not domainTaggedRequest.
There was a problem hiding this comment.
Got it. So some of the generated method never call that branch which uses callWithDomainAndShardScope and all history task related methods are in that category. Would be nice to change code gen template to avoid spitting unused code into each function.
taylanisikdemir
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add task category tag to history tasks metrics
Why?
Improve metrics
How did you test it?
verified in dev2
Potential risks
Release notes
Documentation Changes