Add size-based cache config flags for history event and execution cache #6817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timl3136
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
fimanishi
reviewed
Apr 14, 2025
taylanisikdemir
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added dynamic config flags for enabling size-based caching in the history event and execution caches. These flags propagate to the cache layer and activate size-based behavior when enabled. A new config for controlling the byte size of the execution cache was also introduced (the event size config already exists).
Why?
This allows us to gradually roll out size-based caching per component and provides a quick rollback mechanism if needed. Without feature flags, every change would require a PR and release, which is inefficient and time-consuming.
How did you test it?
Local env tests as well as unit tests.
Potential risks
Minimal risk, as the new flags default to false and won’t impact behavior unless explicitly enabled.
Release notes
Documentation Changes