[common][dynamicconfig] Move dynamic config to fx Module #6828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
force-pushed
the
dynamicconfigfx
branch
from
5a2cd09 to
2247310
Compare
3vilhamster
commented
Apr 16, 2025
| @@ -192,8 +192,8 @@ func getCadencePackageDir() (string, error) { | |||
| if err != nil { | |||
| panic(err) | |||
| } | |||
| cadenceIndex := strings.LastIndex(cadencePackageDir, "/cadence/") | |||
| cadencePackageDir = cadencePackageDir[:cadenceIndex+len("/cadence/")] | |||
| cadenceIndex := strings.LastIndex(cadencePackageDir, "cadence/") | |||
There was a problem hiding this comment.
This broke my setup with a folder named /my-cadence/.
I've copied the solution from nosql version
3vilhamster
force-pushed
the
dynamicconfigfx
branch
from
2247310 to
137dca2
Compare
| p.Logger.Info("initialising NOP dynamic config client") | ||
| res = dynamicconfig.NewNopClient() | ||
| } else if err != nil { | ||
| p.Logger.Error("creating dynamic config client failed, using no-op config client instead", tag.Error(err)) |
There was a problem hiding this comment.
Error cases silently switching to no-op config doesn't sound right. I know that's also the current behavior but we should consider failing startup if there's a misconfiguration for dynamicconfigs.
There was a problem hiding this comment.
That's a good point, but I'm unsure how safe it is. It's something to consider for v2: a stricter startup to ensure no missing dependencies.
taylanisikdemir
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I introduce dynamicconfigfx.Module to inject dynamic config to fx application.
Why?
This is one of the few common dependencies that exist outside of the resource and can be initialized separately.
Also, it ensures a single instance that provides consistent reads of dynamic config if there are multiple services running in one binary.
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes