Fix flaky integration test in TestConcurrentlyForkAndAppendBranches #6860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timl3136
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
shijiesheng
reviewed
Apr 30, 2025
| return true | ||
| }) | ||
| err = s.deleteHistoryBranch(ctx, masterBr) | ||
| s.Nil(err) | ||
|
|
||
| branches = s.descTree(ctx, treeID) | ||
| // Add retry logic for branch cleanup verification |
There was a problem hiding this comment.
nit: use s.Eventually() for simplification
shijiesheng
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Resolve flakiness in the
TestConcurrentlyForkAndAppendBranchesintegration test by implementing retry logic for message publishing operations.Why?
Flaky tests cause unwanted delay in testing and can create noise which it makes us unlikely to locate issues detected by tests.
How did you test it?
Run the integration test for 20 times using following script:
docker-compose -f docker/buildkite/docker-compose-local.yml run --rm integration-test-cassandra go test ./host/persistence/cassandra/... -run TestCassandraHistoryPersistence/TestConcurrentlyForkAndAppendBranches -count=20Potential risks
Release notes
Documentation Changes