Serialize shard data #6869
Serialize shard data #6869
Conversation
Shaddoll
force-pushed
the
p1
branch
4 times, most recently
from
e4f0ab3 to
87c09e7
Compare
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
host/dynamicconfig.go
Outdated
| @@ -48,6 +48,7 @@ var ( | |||
| dynamicproperties.EnableConsistentQueryByDomain: true, | |||
| dynamicproperties.MinRetentionDays: 0, | |||
| dynamicproperties.WorkflowDeletionJitterRange: 1, | |||
| dynamicproperties.ReadNoSQLShardFromDataBlob: true, | |||
There was a problem hiding this comment.
should we make this false for some tests to have some coverage for current implementation?
There was a problem hiding this comment.
I'm not sure the best way to handle this. I have to run the integration tests with this flag on to test the change before turning it on in staging environments.
There was a problem hiding this comment.
We have this problem in general for dynamic configs. Since we cannot run separate integration tests for each cartesian product of config values we go with a pre-picked values. I recommend adding at least one basic test that uses the previous value. We need to have coverage for both
There was a problem hiding this comment.
Added a new test in host/persistence package for Cassandra.
Shaddoll
force-pushed
the
p1
branch
4 times, most recently
from
9ecc5f6 to
1680590
Compare
* Serialize shard data * Introduce metrics client to nosql stores
What changed?
Why?
To migrate shard data from Cassandra typed column to serialized blob column so that we don't need to update our schema when introducing new field to shard data. This is a preparation work for history queue revamp.
How did you test it?
unit tests and integration tests
Potential risks
Release notes
Documentation Changes