[domain deprecation]Integrate domain deprecation workflow with CLI #6870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazi-yestemirova
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| "github.com/uber/cadence/tools/common/commoncli" | ||
| "github.com/uber/cadence/tools/common/flag" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
please update unit tests of this file
taylanisikdemir
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR connects the domain deprecation workflow to the CLI's deprecate domain command. When a user runs
cadence domain deprecate, the CLI will now:The force flag has been removed since the domain is now deprecated early in the process, before workflow termination and cleanup. This ensures a more controlled deprecation sequence where the domain is marked as deprecated first, followed by proper cleanup of workflows.
Why?
The goal is to provide a safe and automated way to deprecate domains, ensuring all workflows are properly terminated and validated before the deprecation is considered complete.
How did you test it?
unit tests & local testing
Potential risks
Release notes
Documentation Changes