Added retries on creating the cassandra client. #6877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
jakobht
force-pushed
the
retryCassClientCreation
branch
from
09b1983 to
d3b65c7
Compare
…sing a retry policy.
jakobht
force-pushed
the
retryCassClientCreation
branch
from
d3b65c7 to
9b55315
Compare
3vilhamster
reviewed
May 2, 2025
| ) | ||
|
|
||
| func TestNewCQLClientWithRetry(t *testing.T) { | ||
| mockClient, mockSession, mockClock := setUpMocks(t) |
There was a problem hiding this comment.
Please add
defer goleak.VerifyNone(t)
And not leak goroutines
There was a problem hiding this comment.
Added and fixed the go-routine. It's relatively big change to the test, so please re-review :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now do 3 attempts to create the client, with exponential backoff using a retry policy.
Also removed deprecated mock clock and replaced with the new timeSource
Why?
We sometimes see trancient failures on creating the client, currently this causes the whole server to crash during startup, this adds a few retries before giving up
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes