[sharddistributor] Fix missalignment on etcd modules #6921
Merged
+26
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
dkrotx
approved these changes
May 15, 2025
|
We will have to align once in a while with the monorepo. But most of the updates should be backward compatible, or it will break our tests and we will have to update it in our repo and merge back to the monorepo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Force downgraded go.etcd.io/etcd/client/pkg/v3 to the previous version.
ETCD folks are using multimodule setup with loose dependencies and replaces inside their repo. That means that when I've downgraded go.etcd.io/etcd/client/v3 to the 3.5.5, go.etcd.io/etcd/client/pkg/v3 keeps pointing the previous version.
TIL that go modules works poorly in multi module scenario.
Why?
To pull minimal changes to the monorepo.
How did you test it?
Potential risks
Release notes
Documentation Changes