Add capability to have multiple domains in replication simulation #6923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fimanishi
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
May 15, 2025
| @@ -79,7 +79,7 @@ func main() { | |||
| } | |||
|
|
|||
| dispatcher := yarpc.NewDispatcher(yarpc.Config{ | |||
| Name: simTypes.WorkerIdentityFor(*clusterName), | |||
| Name: simTypes.WorkerIdentityFor(*clusterName, "test-domain"), | |||
There was a problem hiding this comment.
I guess we don't need to hardcode test-domain here. you can use another name for dispatcher config
There was a problem hiding this comment.
yeah, I was passing an empty string here. I was testing and forgot to revert it
| Logger: logger, | ||
| MetricsScope: tally.NewTestScope(simTypes.TasklistName, map[string]string{"cluster": *clusterName}), | ||
| for domainName := range simCfg.Domains { | ||
| waitUntilDomainReady(logger, cadenceClient, domainName) |
There was a problem hiding this comment.
there's only 1 /health endpoint and it will be marked ready as soon as first domain is created. I recommend running waitUntilDomainReady in goroutines and wait for both of them to return. Also the /health handler above should return OK if ready == num_domains
Comment on lines
77
to
79
| for domainName := range simCfg.Domains { | ||
| waitUntilWorkersReady(t, domainName) | ||
| } |
There was a problem hiding this comment.
this doesn't need to be done per domain. see my other comment. worker readyness endpoint can deal with multiple domain aspect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add capability to have multiple domains in replication simulation. Allow workflows to target the domain where it will be created and create workers for all registered domains.
Why?
We want to simulate failover and replication involving multiple domains.
How did you test it?
Tested locally with the existing simulations
Potential risks
Release notes
Documentation Changes