[common] metricsfx separation of modules with external tally and without #6928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
|
I don't understand why we want to separate it like this? It looks like we want the scope to be optional. If it's not there we construct it, if it is there we reuse it. |
jakobht
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updated metricsfx to separate FX modules with and without scope.
Why?
Mainly doing it to separate concerns for shard distributor customizations in the monorepo that uses different types for configurations.
The main concern:
If it is not provided, we need a configuration to build it.
I can make it optional, but then there could be missing metrics. Then I'll need to add validation for this config since it has a default noop value, so in case of missing metrics, it can start without metrics.
To make it clearer, I separate modules into two: one when it is configured from the outside and the other when it should be built from the configuration that must be provided.
How did you test it?
Added unit tests
Potential risks
Release notes
Documentation Changes