Restructure workflows for replication simulation #6936
Merged
+32
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
approved these changes
May 19, 2025
| @@ -78,7 +73,7 @@ func TestWorkflow(ctx workflow.Context, input types.WorkflowInput) (types.Workfl | |||
| return types.WorkflowOutput{Count: count}, nil | |||
| } | |||
|
|
|||
| func TestActivity(ctx context.Context, input string) (string, error) { | |||
| func FormatStringActivity(ctx context.Context, input string) (string, error) { | |||
| logger := activity.GetLogger(ctx) | |||
| logger.Info("testActivity started") | |||
There was a problem hiding this comment.
nit: update log with new name of activity
fimanishi
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Changed the folder/file structure for workflows in replication simulation
Why?
The previous structure assumed only one workflow. This structure gives us more flexibility and better organization.
How did you test it?
The changes are supposed to maintain the same behavior. Tested locally successfully.
Potential risks
Release notes
Documentation Changes