Fix gomod lint #6938
Merged
Fix gomod lint #6938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check didn't actually check anything:
```
❯ go get github.com/uber/cadence/common/archiver/gcloud
...
❯ make .build/gomod-lint
checking for direct submodule dependencies in root go.mod...
✓ No direct dependency on cmd/server
✓ No direct dependency on internal/tools
✓ No direct dependency on common/archiver/gcloud
✓ No direct dependency on service/sharddistributor/leader/leaderstore/etcd
❯ grep common/archiver/gcloud go.mod
github.com/uber/cadence/common/archiver/gcloud v0.0.0-20250520010807-4b03f0710bac // indirect
```
You might get a `require ...` line if you add it by hand, but any `go mod tidy` will bundle it with others in a
```
require (
...
)
```
which needs a less-picky regex to catch.
Or `go mod why` or something, but grep does seem fine here.
Groxx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I was looking closer at bd127c3 anyway...
The check didn't actually check anything:
You might get a
require ...line if you add it by hand, but anygo mod tidywill bundle it with others in awhich needs a less-picky regex to catch.
Or
go mod whyor something, but grep does seem fine here.