-
Notifications
You must be signed in to change notification settings - Fork 843
Add active clusters config to domain schema #6945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
taylanisikdemir
merged 9 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/active_active_db_schema
May 28, 2025
Merged
Add active clusters config to domain schema #6945
taylanisikdemir
merged 9 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/active_active_db_schema
May 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66d3dfd
to
b027382
Compare
Shaddoll
reviewed
May 27, 2025
Shaddoll
reviewed
May 27, 2025
Does persistence tests cover the change? |
They cover domain crud operations but not activeclusters field updates. let me add a few cases there |
Shaddoll
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
types.ActiveClusters
serialized. SQL stores already serialize the whole domain info so no schema change there.Detailed Description
[In-depth description of the changes made to the schema or interfaces, specifying new fields, removed fields, or modified data structures]
Impact Analysis
It's not backward compatible so we are not going to start populating this field until DB schema is upgraded and no rollbacks anticipated.
Testing Plan
Added/updated relevant unit tests to cover the new fields as well as absence of new fields.
Added extra test cases to UpdateDomain handler for active-active cases.
No changes
No changes
Not needed.
Rollout Plan
What is the rollout plan?
Land the change, create prerelease and run schema upgrade tool before deploying the new version
Does the order of deployment matter?
As usual, first apply DB schema change then deploy binary.
Is it safe to rollback? Does the order of rollback matter?
It's safe to rollback the code changes because it's not going to be used anytime soon.
Is there a kill switch to mitigate the impact immediately?
Rollback.