Fix type with space between limit and precision in SQLiteAdapter (#2329)

Signed-off-by: Matthew Peveler <[email protected]>

Author: MasterOdin

src/Phinx/Db/Adapter/SQLiteAdapter.php

@@ -1794,7 +1794,7 @@ public function getPhinxType(?string $sqlTypeDef): array
         if ($sqlTypeDef === null) {
             // in SQLite columns can legitimately have null as a type, which is distinct from the empty string
             $name = null;
-        } elseif (!preg_match('/^([a-z]+)(_(?:integer|float|text|blob))?(?:\((\d+)(?:,(\d+))?\))?$/i', $sqlTypeDef, $match)) {
+        } elseif (!preg_match('/^([a-z]+)(_(?:integer|float|text|blob))?(?:\((\d+)(?:,[ ]*(\d+))?\))?$/i', $sqlTypeDef, $match)) {
             // doesn't match the pattern of a type we'd know about
             $name = Literal::from($sqlTypeDef);
         } else {

tests/Phinx/Db/Adapter/SQLiteAdapterTest.php

@@ -2841,7 +2841,9 @@ public function provideSqlTypes()
             ['jsonb_text', ['name' => SQLiteAdapter::PHINX_TYPE_JSONB, 'limit' => null, 'scale' => null]],
             ['uuid', ['name' => SQLiteAdapter::PHINX_TYPE_UUID, 'limit' => null, 'scale' => null]],
             ['uuid_text', ['name' => SQLiteAdapter::PHINX_TYPE_UUID, 'limit' => null, 'scale' => null]],
-            ['decimal', ['name' => Literal::from('decimal'), 'limit' => null, 'scale' => null]],
+            ['decimal', ['name' => SQLiteAdapter::PHINX_TYPE_DECIMAL, 'limit' => null, 'scale' => null]],
+            ['decimal(10,5)', ['name' => SQLiteAdapter::PHINX_TYPE_DECIMAL, 'limit' => 10, 'scale' => 5]],
+            ['decimal(10, 5)', ['name' => SQLiteAdapter::PHINX_TYPE_DECIMAL, 'limit' => 10, 'scale' => 5]],
             ['point', ['name' => Literal::from('point'), 'limit' => null, 'scale' => null]],
             ['polygon', ['name' => Literal::from('polygon'), 'limit' => null, 'scale' => null]],
             ['linestring', ['name' => Literal::from('linestring'), 'limit' => null, 'scale' => null]],
@@ -2917,7 +2919,7 @@ public function provideSqlTypes()
             ['JSONB_TEXT', ['name' => SQLiteAdapter::PHINX_TYPE_JSONB, 'limit' => null, 'scale' => null]],
             ['UUID', ['name' => SQLiteAdapter::PHINX_TYPE_UUID, 'limit' => null, 'scale' => null]],
             ['UUID_TEXT', ['name' => SQLiteAdapter::PHINX_TYPE_UUID, 'limit' => null, 'scale' => null]],
-            ['DECIMAL', ['name' => Literal::from('decimal'), 'limit' => null, 'scale' => null]],
+            ['DECIMAL', ['name' => SQLiteAdapter::PHINX_TYPE_DECIMAL, 'limit' => null, 'scale' => null]],
             ['POINT', ['name' => Literal::from('point'), 'limit' => null, 'scale' => null]],
             ['POLYGON', ['name' => Literal::from('polygon'), 'limit' => null, 'scale' => null]],
             ['LINESTRING', ['name' => Literal::from('linestring'), 'limit' => null, 'scale' => null]],