Fix custom column types not working anymore.

[ndm2]

fixes #1810

[ndm2]

Coverage decrease seems to be a "lie", everything that supposedly decreased, was just as uncovered before.

[roblperry]

@ndm2 , in testMigrationWithCustomColumnTypes you set the expected limit to null for pgsql.

$limit = 15;
if ($adapter->getAdapterType() === 'pgsql') {
    $limit = null;
}

and

$limit = 30;
if ($adapter->getAdapterType() === 'pgsql') {
    $limit = null;
}

As it turns out PostgresAdaptor.php always fails to read the limit for char and varchar in get columns. I plan on reporting it as a bug and offering a fix, but my fix breaks testMigrationWithCustomColumnTypes due to the carve-outs for pgsql.

Is there some constructive reason that the limit should be null in these cases, or were you simply avoiding the tangent of needing to hunt and fix what I am trying to fix?

Either way, thanks for adding tests while contributing ahead of me. It increases my chances of not doing harm.

[ndm2]

@roblperry I think I just mixed it up with something else, and mistakenly accepted this as the intended behavior. Looking at the history of how this bug slipped in, there seems to be more incorrect and/or missing coverage :(