Skip to content

Min PHP 7.3 #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Min PHP 7.3 #2167

merged 4 commits into from
Jan 23, 2023

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Jan 7, 2023

No need to work with 7.2...8.2 now

https://github.com/cakephp/cakephp/blob/4.x/composer.json#L25 is even 7.4 already

@dereuromark dereuromark added this to the 0.13.x milestone Jan 7, 2023
Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also update the require.php value to be >=7.3 as well so that someone doesn't try to install phinx on 7.2 and it's broken since we're not targeting it anymore.

@MasterOdin
Copy link
Member

MasterOdin commented Jan 7, 2023

I would consider dropping support for a PHP version a breaking change, and so would necessitate a 0.14.0 release, and so I'd want to hold off doing this until the 0.13.x release line is more stabilized. Additionally, on upping the min version, I think we should drop both 7.2 and 7.3 and use 7.4 and above to be inline with the CakePHP projects.

@dereuromark
Copy link
Member Author

1.x will be 8.1 probably
But dropping a Version is a minor (semantic)

@dereuromark
Copy link
Member Author

I dont see a file require.php anywhere.

@MasterOdin
Copy link
Member

I meant the php key/value pair under the require object in the composer.json. It's currently set to >=7.2 which should be updated.

@MasterOdin
Copy link
Member

But dropping a Version is a minor (semantic)

I guess? Except that since we're still using 0.x versioning, it means that part of the way through a major release, some people may be locked out of a future release since we cannot go back and do bugfix releases. I also feel like 0.13.x has ended up not being as stabilized yet as I'd like so I wouldn't want to get people on PHP 7.2 stuck with a slightly buggy version. There's also not really anything in PHP 7.3 that'd be incorporated into phinx beyond bumping dependency/devDependency versions.

All in all, I'd like to hold off doing this until we see 0.13.x stabilized, and are looking forward to a 0.14.0 release, and then drop minimally PHP 7.2 and 7.3, and support PHP 7.4 purely for compatibility reasons with cakephp/migrations.

@dereuromark
Copy link
Member Author

Anyone still using < 7.4 is seriously in trouble either way.
I doubt setting 7.3 as minimum has any impact on any normal user of the tool.

As for the rest: Yes, it was rather a rollercoaster, partially due to everyone only being able to commit very small to this project.

But raising the minimum is a super simple task that composer is fully in control, I dont see an issue here.

@dereuromark dereuromark merged commit 2880900 into 0.x Jan 23, 2023
@dereuromark dereuromark deleted the php73 branch January 23, 2023 10:46
@dereuromark
Copy link
Member Author

dereuromark commented Jan 23, 2023

Given EOL in 2020 I removed support here now, we will make this clear in the release notes.
But it should simply not be used anymore in favor of 7.3+ on all systems out there.
Composer will give a clear feedback here if violated (and not download updates), therefore no BC issue per se.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants