Require php-64bit to install phinx #2169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <[email protected]>
MasterOdin
commented
Jan 7, 2023
| your first database migration. Phinx is just about migrations without all the | ||
| bloat of a database ORM system or application framework. | ||
|
|
||
| Phinx requires a 64-bit version of PHP to function. |
There was a problem hiding this comment.
The only real change here is the addition of this line. I only added line breaks to the above paragraph.
dereuromark
reviewed
Jan 7, 2023
| @@ -36,7 +36,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=7.2", | |||
| "php-64bit": ">=7.2", | |||
There was a problem hiding this comment.
Neither did I until working on this ticket, but https://getcomposer.org/doc/01-basic-usage.md#platform-packages makes it sound like it'll work how we'd want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR modifies the
composer.jsonsuch that now installing phinx will only work on php-64bit, which should hopefully avoid errors as shown in #2111 going forward. I think that the number of people using 32-bit PHP is probably low enough to not worry much about having them be stuck on an old version of phinx not realizing it'll break for them, where it's just people using PHP on windows and wherever they're getting PHP is pulling the modern x64 builds.An alternative approach would be to rewrite phinx such that
$versioncould be a string throughout and that we use an alternative data structure than an associative array for sorting migrations keyed by the version (due to how PHP implicitly cast integer looking keys to integers), but I'd say that's a lot of work to benefit a very small number of people.