Allow Table::addColumn() to use type from Column object again #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
force-pushed
the
table-nullable-type
branch
from
46cf122 to
30ecd50
Compare
|
Should the exception in that method maybe use |
That seems to make sense. The type can be invalid when defined by either Column or string. |
othercorey
force-pushed
the
table-nullable-type
branch
from
30ecd50 to
b4811d3
Compare
MasterOdin
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #2218 (comment)
I think this was removed after fixing a test that passed an invalid null, but we should allow the Column to define the type.