Fix performance degradation for bulk inserts #2354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes performance degradation for bulk inserts that was introduced in #2348. The issue was that for the new function I introduced (
getInsertParameters
), we were doing anarray_merge
to append its return value to our building list of parameters. While this worked, as we were making a copy of the$params
array for each row to be inserted, for enough rows, it would become very slow. By using pass by reference, and just appending to the same array throughout, managed to achieve a great speed-up, while maintaining the DRY intention ofgetInsertParameters
.By moving to a pass by reference setup, given the following migration:
I was able to reduce the time it took for sqlite to run this from 41.8165s to 0.3525s.