Skip to content

PHP 8.1 support #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 28, 2022
Merged

PHP 8.1 support #848

merged 5 commits into from
Mar 28, 2022

Conversation

p4veI
Copy link

@p4veI p4veI commented Mar 21, 2022

Hello

In this MR I'm addressing Issue #840 & Switching required php version to 8.0 (7.4 support ends this year, would be nice to move on)

WDYT?

@p4veI
Copy link
Author

p4veI commented Mar 22, 2022

On second thought adding #[\ReturnTypeWillChange] on the methods that produce warnings in php 8.1 will not cause any BCs and can be added safely with support for older php releases. Updated.

@calcinai
Copy link
Owner

@p4veI you're right, probably safer for now!

@calcinai calcinai closed this Mar 28, 2022
@calcinai calcinai reopened this Mar 28, 2022
@calcinai calcinai merged commit d3dc89d into calcinai:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants