Clean: update references to modes prod and demo #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemannd
force-pushed
the
rm-prod_demo_modes
branch
2 times, most recently
from
84556db to
fbe871e
Compare
There was a problem hiding this comment.
Looks good but please remove change on RUNNING_ENV.
Also I'm not sure what CLN is your commit message stands for. To me it means like Comitato di Liberazione Nazionale 😄
README.rst
Outdated
| ignore_if: test "${RUNNING_ENV}" != "prod" | ||
| ignore_if: test "${RUNNING_ENV}" != "full" |
There was a problem hiding this comment.
It's MARABUNTA_MODE that is either full or sample.
marabunta/parser.py
Outdated
| ignore_if: test "${RUNNING_ENV}" != "prod" | ||
| ignore_if: test "${RUNNING_ENV}" != "full" |
|
Thanks for the review. PR updated (unless the commit name). Once the current change is ok for you I will push force with:
|
leemannd
changed the title
grindtildeath
approved these changes
May 2, 2024
These two modes where deprecated in favor of: prod->full,demo->sample - full: mode that will launch scripts that are dependent to production data (not launcher by ci - sample: these are sample related to the customers project. We dont want to mixup with odoo demo data
leemannd
force-pushed
the
rm-prod_demo_modes
branch
from
641607f to
bdcc491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two modes where deprecated in favor of: prod->full,demo->sample