Skip to content

Bumped all dependencies / TF 0.14.5 / TFE 0.12.0 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

Bumped all dependencies / TF 0.14.5 / TFE 0.12.0 #131

merged 1 commit into from
Feb 3, 2021

Conversation

mvisonneau
Copy link
Contributor

@mvisonneau mvisonneau commented Jan 12, 2021 •
edited
Loading 

~$ go get -u ./...
~$ go mod tidy

@raphink
Copy link
Contributor

raphink commented Jan 14, 2021

Does this need a rebase with #132 merged?

@mvisonneau
Copy link
Contributor Author

I feel that it should be fine 🤔

@coveralls
Copy link

coveralls commented Jan 14, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 13.818% when pulling 1010af3 on mvisonneau:bumped_deps into 997f8d8 on camptocamp:master.

@raphink
Copy link
Contributor

raphink commented Jan 14, 2021

Ah, the build passes now, I just needed to restart it it seems. However, there is now a conflict on go.mod

@mvisonneau
Copy link
Contributor Author

Ah right, I just rebased it should be fine now 👍

@raphink
Copy link
Contributor

raphink commented Jan 16, 2021

It's still failing to build

@mvisonneau
Copy link
Contributor Author

Indeed my bad, most likely related to #133 🙇

@raphink
Copy link
Contributor

raphink commented Feb 3, 2021

I've merged #133 . Can you rebase please @mvisonneau ?

@mvisonneau mvisonneau changed the title Bumped all dependencies / TF 0.14.4 / TFE 0.11.1 Bumped all dependencies / TF 0.14.5 / TFE 0.12.0 Feb 3, 2021
@mvisonneau
Copy link
Contributor Author

done, @raphink! 😃

@mvisonneau
Copy link
Contributor Author

mvisonneau commented Feb 3, 2021 •
edited
Loading

omg I messed up 😓 , one sec!

@mvisonneau
Copy link
Contributor Author

mvisonneau commented Feb 3, 2021 •
edited
Loading

ok, good to go now! 👌

@raphink
Copy link
Contributor

raphink commented Feb 3, 2021

Let's wait for Travis 👷⌚

@raphink raphink merged commit fe3d11e into camptocamp:master Feb 3, 2021
@mvisonneau mvisonneau deleted the bumped_deps branch February 3, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvisonneau @raphink @coveralls