undefined is not a function error from upgraded paths-js in many example app charts

[marzolfb]

It appears I broke many of the charts on the example app in Android specifically on d0de1e3 when upgrading paths-js from 0.3.4 to 0.4.5. I see the following error:

undefined is not a function (evaluating 'data.entries()[typeof Symbol==='function'?Symbol.iterator:'@@iterator']()')

on every type of chart other than the line charts (StockLine and SmoothLine)

[Jarda8]

I just updated the library and have the same error.

[marzolfb]

Thanks @Jarda8 for reaffirming that others are experience this.

I'll admit, I'm struggling a bit with this one. The "easy" thing to do would be to go back to the old version of paths-js (0.3.4) in effect before d0de1e3 (which upgraded paths-js 0.4.5) but then that would mean rolling back the feature of scaling the chart independent of the data with min/max and ability to specify rectangular regions on line charts.

I'll point out what I've discovered this far about the issue and see if others have any pointers to address the issue...

Just focusing on the pie chart source code in paths-js (though the pattern is repeated for other types of charts), this ES6-based line seems to be the start of the problem:

for (let [i, item] of data.entries())

When the paths-js build process invokes babel to turn this into "older javascript" (which is what you are pulling down when you do npm install paths-js), it translates that line into this line:

for (var _iterator = data.entries()[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {

The odd thing here is that I only see the error in the Android simulator and not the iOS simulator which makes me think that there are actually different Javascript engines in play on both simulators that are interpreting the babel-output javascript differently. But if you read the Javascript Environment page on the react-native docs, you see this:

On iOS simulators and devices, Android emulators and devices React Native uses JavaScriptCore which is the JavaScript engine that powers Safari. On iOS JSC doesn't use JIT due to the absence of writable executable memory in iOS apps.

which leads me to believe I should be seeing the same behavior on both emulators, but I don't???

I did also come across a seemingly-related issue here but none of the hints in there have led me to discover (yet) what needs to change with the paths-js transpiled code to make this not produce an error.

Ultimately once I (or someone else) figure out what the fix is, an issue/PR will need to be submitted to paths-js to get this issue addressed. Given that, it may be better to rollback to the old paths-js version and lose the extra functionality to get fully functional charts across the board.

Anyone else have any thoughts on anything I've mentioned above?

[marzolfb]

It turns out that using the Babel polyfill solves the problem. Working on a PR to fix this now...

[jaredsmith]

Great catch, @marzolfb!

[tiaaaa123]

@marzolfb Unfortunately, it doesn't seem to fix the problem entirely. I'm still having this issue on Android. (Using a Pie Chart)
My version of react-native-pathjs-charts

    "react-native-pathjs-charts": "0.0.25",

[marzolfb]

@tiaaaa123 - What is the output of this for you in your app:

npm list react-native react-native-svg paths-js

?

[tiaaaa123]

@marzolfb

├── UNMET PEER DEPENDENCY eslint-plugin-jsx-a11y@3.0.2
├── react-native@0.40.0 
└─┬ react-native-pathjs-charts@0.0.25
  ├── paths-js@0.4.5 
  └── react-native-svg@4.5.0 

[marzolfb]

@tiaaaa123
Are you running the example app or your own app?
react-native-pathjs-charts is expecting react-native >= 0.41 - what happens if you upgrade?
Is it the Pie chart only or are you having issues with other chart types as well?

[tiaaaa123]

@marzolfb I'm running my own app, but with the example here : https://github.com/capitalone/react-native-pathjs-charts/wiki

Upgraded to :

├── UNMET PEER DEPENDENCY eslint-plugin-jsx-a11y@3.0.2
├── react-native@0.41.2 
└─┬ react-native-pathjs-charts@0.0.25
  ├── paths-js@0.4.5 
  └── react-native-svg@4.5.0 

EDIT: After trying them all, i found that the Tree, Pie, Bar, Scatterplot and the Radar are not working on android with the version previously said. Using only the data and the options of the wiki

[marzolfb]

I'm having problems reproducing this in the example app included with this project. The data/options on the wiki site is taken directly from the example app in this repository. I'm not even sure what I can do to reproduce the UNMET PEER DEPENDENCY eslint-plugin-jsx-a11y@3.0.2 portion of the output you have above. If you can resolve your UNMET PEER DEPENDENCY, does the issue still persist?