This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Fix pie chart centering #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgladkov
commented
Apr 11, 2017
| @@ -84,13 +84,7 @@ export default class PieChart extends Component { | |||
| R = (R || (this.props.options && this.props.options.R)) | |||
| R = (R || radius) | |||
|
|
|||
| let chart = Pie({ | |||
| center: this.props.center || (this.props.options && this.props.options.center) || [0,0] , | |||
There was a problem hiding this comment.
Here we have center set to [0, 0] by default.
dgladkov
commented
Apr 11, 2017
| slices = chart.curves.map( (c, i) => { | ||
| let fill = (c.item.color && Colors.string(c.item.color)) || this.color(i) | ||
| let stroke = typeof fill === 'string' ? fill : Colors.darkenColor(fill) | ||
| return ( | ||
| <G key={ i } x={x} y={y}> |
There was a problem hiding this comment.
Here actual centering was applied.
marzolfb
approved these changes
Apr 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optionsprop is supplied but does not contain marginscenteroption actually meant "x and y shift from the center" instead of "x and y position of the actual center".this.props.data.length === 1codepath.