Skip to content

CIP-0147? | Wallet Connector - Own-data wallet #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nazrhom
Copy link
Contributor

@nazrhom nazrhom commented Feb 6, 2025

A wallet extension for an own-data wallet. This builds upon the work done in CIP-144 to provide a generic wallet connector API. In this CIP we propose an extension API for an own-data wallet, which is equivalent to what CIP-30 offers today

rendered version on fork

@nazrhom nazrhom changed the title Own data wallet CIP Own-data wallet Feb 6, 2025
@rphair rphair changed the title Own-data wallet CIP-???? | Own-data wallet Feb 6, 2025
@rphair rphair added State: Triage Applied to new PR afer editor cleanup on GitHub, pending CIP meeting introduction. Category: Wallets Proposals belonging to the 'Wallets' category. labels Feb 6, 2025
@rphair
Copy link
Collaborator

rphair commented Feb 6, 2025

@Ryun1 @Crypto2099 @nazrhom - since the CIP-0030 extensions recently inventoried here (https://github.com/Ryun1/CIPs/blob/cip30-extension-discoverability/CIP-0030/extensions-register.md) have all been given the CIP title prefix Web-Wallet Bridge, is there another category term that we could or should use to group the CIP-0144 compatible extensions?

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nazrhom tagging this Triage puts it up for introduction at our next CIP meeting (https://hackmd.io/@cip-editors/106) where hopefully #957 will also be ready for a more detailed review. Hopefully you can attend so we can talk more about the new class of wallet extensions that is emerging.

nazrhom and others added 2 commits February 7, 2025 10:36
Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Robert Phair <[email protected]>
@nazrhom
Copy link
Contributor Author

nazrhom commented Feb 7, 2025

Thanks for your review @rphair I will be at the next meeting!

@rphair rphair added State: Confirmed Candiate with CIP number (new PR) or update under review. and removed State: Triage Applied to new PR afer editor cleanup on GitHub, pending CIP meeting introduction. labels Feb 18, 2025
@rphair rphair changed the title CIP-???? | Own-data wallet CIP-0147? | Wallet Connector - Own-data wallet Feb 18, 2025
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nazrhom for bringing this through rounds of refinement on GitHub and the last hour's CIP meeting. Please also rename the containing directory to CIP-0147 and then update the proposal link in the first comment. 🎉

The suggestion to similarly tag CIP-0144 -compliant extensions is encouraged by CIP-0001 (https://github.com/cardano-foundation/CIPs/blob/master/CIP-0001/README.md#naming-cips-with-similar-subjects) and the recommended title change should help keep developer eyes fixed on the newer standard.

@rphair
Copy link
Collaborator

rphair commented Apr 11, 2025

@nazrhom it saves a lot of work for the editors, and creates better record-keeping in the long run, when you can "Commit suggestion" through the GitHub UI rather than pushing something into your own branch that incorporates those same suggestions from the review but then leaves those conversations for the editors to clean up.

The main load of unnecessary & easily avoidable work for the editors is having to manually double-check all the code changes that were suggested vs. the ones that were made. GitHub UI makes it easy to avoid that problem but only if we use it that way. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Wallets Proposals belonging to the 'Wallets' category. State: Confirmed Candiate with CIP number (new PR) or update under review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants