-
Notifications
You must be signed in to change notification settings - Fork 2
Drop CentOS 7 and 8 support #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd be delighted to merge "Drop Centos 7 and 8" support, but I'd also be merging 6 other unrelated commits. |
Yes they are all part of #45, CI show that CentOS 7 & 8 are broken so I removed them in a separate PR because this change is backwards incompatible. I rebased this branch specific changes on top of master. |
These versions or CentOS have reached end-of-life and the images used for CI are not available anymore. As we cannot ensure these legacy systems are still working with the module, remove them from metadata.json.
Dang! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might as well drop the whole CentOS section, don't you think ?
I think that CentOS 9 / 10 (aka CentOS Stream) can still be tested with the vox tooling. Those would be added with the corresponding versions of RedHat / AlmaLinux / Rocky / etc. I have not tried it, and decommissioned the last rpm-based Operating System from our fleet last year, so it is not something I will spend time on. Also, adding OS is a minor change so will not result in a major version bump so I am fine with keeeping this as it is (so that CentOS is still listed as supported on the Forge, but is untested and so if people have trouble they know they can send fix PRs). I am also fine for removing it completely if you prefer the module not listing CentOS as supported at all. Also, I belive that with the updated tooling (see ccin2p3/modulesync_config#7) outdated OS are skipped, and so these failures would not appear anymore, with CentOS 7 & 8 still listed as supported. Not ideal since because they are untested they can silently break, but still a valid option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
These versions or CentOS have reached end-of-life and the images used
for CI are not available anymore. As we cannot ensure these legacy
systems are still working with the module, remove them from
metadata.json.
Also include:Add support for FreeBSD #45