Skip to content

Drop CentOS 7 and 8 support #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Drop CentOS 7 and 8 support #46

merged 1 commit into from
Jun 5, 2025

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented Jan 13, 2025

These versions or CentOS have reached end-of-life and the images used
for CI are not available anymore. As we cannot ensure these legacy
systems are still working with the module, remove them from
metadata.json.

Also include:

@faxm0dem
Copy link
Member

I'd be delighted to merge "Drop Centos 7 and 8" support, but I'd also be merging 6 other unrelated commits.

@smortex
Copy link
Collaborator Author

smortex commented Apr 24, 2025

Yes they are all part of #45, CI show that CentOS 7 & 8 are broken so I removed them in a separate PR because this change is backwards incompatible. I rebased this branch specific changes on top of master.

These versions or CentOS have reached end-of-life and the images used
for CI are not available anymore.  As we cannot ensure these legacy
systems are still working with the module, remove them from
metadata.json.
@smortex
Copy link
Collaborator Author

smortex commented Apr 24, 2025

This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see actions/runner-images#11101

Dang!

Copy link
Member

@faxm0dem faxm0dem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well drop the whole CentOS section, don't you think ?

@smortex
Copy link
Collaborator Author

smortex commented Apr 28, 2025

We might as well drop the whole CentOS section, don't you think ?

I think that CentOS 9 / 10 (aka CentOS Stream) can still be tested with the vox tooling. Those would be added with the corresponding versions of RedHat / AlmaLinux / Rocky / etc.

I have not tried it, and decommissioned the last rpm-based Operating System from our fleet last year, so it is not something I will spend time on. Also, adding OS is a minor change so will not result in a major version bump so I am fine with keeeping this as it is (so that CentOS is still listed as supported on the Forge, but is untested and so if people have trouble they know they can send fix PRs). I am also fine for removing it completely if you prefer the module not listing CentOS as supported at all.

Also, I belive that with the updated tooling (see ccin2p3/modulesync_config#7) outdated OS are skipped, and so these failures would not appear anymore, with CentOS 7 & 8 still listed as supported. Not ideal since because they are untested they can silently break, but still a valid option.

Copy link
Member

@faxm0dem faxm0dem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@smortex smortex merged commit 7b759e1 into master Jun 5, 2025
4 of 16 checks passed
@smortex smortex deleted the drop-centos branch June 5, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants