Skip to content

🧱 switch to dedicated reusable MQT workflows #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR switches the reusable workflows from MQT Core to the ones hosted at https://github.com/cda-tum/mqt-workflows. This creates a better separation of concerns and allows for separate versioning of the workflows and the MQT Core library.

Furthermore, this PR adapts the configuration of the continuous deployment job so that the job is also triggered if the respective workflow file is updated. This should help to catch errors as early as possible when dependabot updates the workflow.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added dependencies Pull requests that update a dependency file github_actions continuous integration Anything related to the CI setup labels May 23, 2024
@burgholzer burgholzer self-assigned this May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.5%. Comparing base (2f7d92e) to head (232f028).
Report is 54 commits behind head on main.

Files Patch % Lines
src/mqt/ddsim/provider.py 66.6% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #376     +/-   ##
=======================================
- Coverage   92.7%   92.5%   -0.3%     
=======================================
  Files         37      37             
  Lines       2552    2561      +9     
  Branches     309     309             
=======================================
+ Hits        2368    2370      +2     
- Misses       184     191      +7     
Flag Coverage Δ
cpp 94.5% <ø> (-0.2%) ⬇️
python 87.3% <66.6%> (-0.5%) ⬇️
Files Coverage Δ
src/mqt/ddsim/provider.py 83.3% <66.6%> (-12.2%) ⬇️

... and 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 025966a into main May 23, 2024
71 of 72 checks passed
@burgholzer burgholzer deleted the switch-to-mqt-workflows branch May 23, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant