feat: pass software version from abci to node info #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
previously approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Tested locally by running this PR. celestia-app reports version:
$ celestia-appd version
1.0.0-rc0-122-g16f92dbewhich is confirmed by /status endpoint
$ curl -X GET "http://localhost:26657/status" -H "accept: application/json" | jq
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1093 100 1093 0 0 313k 0 --:--:-- --:--:-- --:--:-- 1067k
{
"jsonrpc": "2.0",
"id": -1,
"result": {
"node_info": {
"protocol_version": {
"p2p": "8",
"block": "11",
"app": "1"
},
"id": "c858506f3cc6381a584d5ea258f547b006dfcaa4",
"listen_addr": "tcp://0.0.0.0:26656",
"network": "private",
"version": "1.0.0-rc0-122-g16f92dbe",
"channels": "40202122233038606100",
"moniker": "private",
"other": {
"tx_index": "on",
"rpc_address": "tcp://0.0.0.0:26657"
}
},
"sync_info": {
"latest_block_hash": "01BFB0704A6BF9D1051CAC8450319A9772777558C5B162D165BB3EE698EF14F6",
"latest_app_hash": "CB7A5276E65C8D28AE35778C0F0905E31CFF3063835F6968FF27B91F8414803B",
"latest_block_height": "9",
"latest_block_time": "2023-07-13T14:24:06.640833Z",
"earliest_block_hash": "D12DD2E2B8DA75DABA05D72D7415615E4D40E5626DA757A1145CCD6865027DF8",
"earliest_app_hash": "E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855",
"earliest_block_height": "1",
"earliest_block_time": "2023-07-13T14:22:38.049966Z",
"catching_up": false
},
"validator_info": {
"address": "98241EA7597330EF1E64068D811A36B3B74177B6",
"pub_key": {
"type": "tendermint/PubKeyEd25519",
"value": "YJs7EDSKNE+m7Nunv2vVusw1+kJ9TdK9YhCTO1AyWrs="
},
"voting_power": "5000"
}
}
}
Co-authored-by: Rootul P <[email protected]>
What's the 122 mean? I assume the last bit is the truncated hash of the commit |
TBH I'm not sure |
rootulp
approved these changes
Jul 13, 2023
staheri14
approved these changes
Jul 13, 2023
| @@ -238,17 +238,17 @@ func (h *Handshaker) NBlocks() int { | |||
| } | |||
|
|
|||
| // TODO: retry the handshake/replay if it fails ? | |||
| func (h *Handshaker) Handshake(proxyApp proxy.AppConns) error { | |||
| func (h *Handshaker) Handshake(proxyApp proxy.AppConns) (string, error) { | |||
There was a problem hiding this comment.
A func description, including what each output represents, would be really useful.
cmwaters
added a commit
that referenced
this pull request
Jul 20, 2023
* pass software version from abci to node info * Update consensus/replay_test.go Co-authored-by: Rootul P <[email protected]>
cmwaters
added a commit
that referenced
this pull request
Jul 24, 2023
* pass software version from abci to node info * Update consensus/replay_test.go Co-authored-by: Rootul P <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1035