Skip to content

Fix build using clang-cl on windows and improve driver detection #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2022
Merged

Fix build using clang-cl on windows and improve driver detection #129

merged 2 commits into from
Sep 4, 2022

Conversation

jambonmcyeah
Copy link
Contributor

No description provided.

bitscher
bitscher reviewed Aug 31, 2022
View reviewed changes
@jambonmcyeah jambonmcyeah force-pushed the main branch 3 times, most recently from 1d6d4ad to b13d2d7 Compare August 31, 2022 04:05
Exzap
Exzap requested changes Aug 31, 2022
View reviewed changes
@jambonmcyeah jambonmcyeah force-pushed the main branch 2 times, most recently from d9de2c2 to a6cb4ca Compare August 31, 2022 14:50
@jambonmcyeah
Copy link
Contributor Author

fixed everything

Tachi107
Tachi107 reviewed Aug 31, 2022
View reviewed changes
@jambonmcyeah jambonmcyeah force-pushed the main branch 3 times, most recently from 89d9ee1 to d13a026 Compare September 1, 2022 22:47
@jambonmcyeah
Copy link
Contributor Author

everything should be fixed

@jambonmcyeah jambonmcyeah force-pushed the main branch 2 times, most recently from c811127 to 647c0fa Compare September 1, 2022 22:55
@jambonmcyeah jambonmcyeah requested a review from Exzap September 1, 2022 22:56
bitscher
bitscher reviewed Sep 3, 2022
View reviewed changes
Tachi107
Tachi107 reviewed Sep 3, 2022
View reviewed changes
Tachi107
Tachi107 reviewed Sep 3, 2022
View reviewed changes
Tachi107
Tachi107 reviewed Sep 3, 2022
View reviewed changes
Copy link
Contributor

@Tachi107 Tachi107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few whitespace-related comments. Also, was src/resource/cemu.rc deleted on purpose?

@Exzap
Copy link
Member

Exzap commented Sep 3, 2022

Also, was src/resource/cemu.rc deleted on purpose?

I got confused by that too, but it's not deleted. They removed some unused #ifdef and changed the encoding from utf16 to utf8 making the file much smaller.

@jambonmcyeah
Copy link
Contributor Author

Also, was src/resource/cemu.rc deleted on purpose?

I got confused by that too, but it's not deleted. They removed some unused #ifdef and changed the encoding from utf16 to utf8 making the file much smaller.

I changed this because clang doesn't support utf16

@Exzap
Copy link
Member

Exzap commented Sep 4, 2022

Looks good to me now. Thanks!

@Exzap Exzap merged commit a54a3ec into cemu-project:main Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitscher bitscher bitscher left review comments

@Tachi107 Tachi107 Tachi107 left review comments

@Exzap Exzap Awaiting requested review from Exzap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jambonmcyeah @Exzap @bitscher @Tachi107