-
Notifications
You must be signed in to change notification settings - Fork 684
Refactor CMake files #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is no way this should be building-- look at what I have done to |
Looked a bit into it and it's complicated, so no quick fix. Seems to only affect commits done after initial pull request. As long as you can confirm it compiles locally I'd merge the pull request. Just let me know when you are done |
Unfortunately I cannot build locally due to CMake not finding the vcpkg installed dependencies. I'll try a CI PR in a bit. |
Re-posting here, as it got lost between all the other comments. From #1 (comment)
|
The fmt stuff is a bit ugly, and will not work when not using vcpkg unless you decide to install version 7.0.2 manually, but that's about as easy as manually installing 7.0.x, which you needed to do anyways. It only needs to exist until we update to 9.x, anyways. |
Why 7.0.2? Every release on the 7.x branch should work just fine (it works with 7.1.3, for example) |
Anyway, the diff is huge, could you split the changes in different commits, where each one contains a single logical change, so that this is easier to review? |
Most of the diff is just from listing the files, the amount of intellectual changes is pretty low. |
Closing in favour of a series of smaller PRs. |
Async pipeline compilation
Just a work in progress, putting it here so nobody doubles up by accident.