Skip to content

Refactor CMake files #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Refactor CMake files #9

wants to merge 1 commit into from

Conversation

Zopolis4
Copy link
Contributor

Just a work in progress, putting it here so nobody doubles up by accident.

@JakobDev JakobDev mentioned this pull request Aug 24, 2022
3 tasks
@Zopolis4
Copy link
Contributor Author

There is no way this should be building-- look at what I have done to gui/CMakeLists.txt. The CI is broken.

@Exzap
Copy link
Member

Exzap commented Aug 26, 2022

There is no way this should be building-- look at what I have done to gui/CMakeLists.txt. The CI is broken.

Looked a bit into it and it's complicated, so no quick fix. Seems to only affect commits done after initial pull request. As long as you can confirm it compiles locally I'd merge the pull request. Just let me know when you are done

@Zopolis4
Copy link
Contributor Author

Unfortunately I cannot build locally due to CMake not finding the vcpkg installed dependencies. I'll try a CI PR in a bit.

@JakobDev
Copy link
Contributor

#12 and #10 have now been merged. These 2 files need to be installed on Unix Systems in the following locations:
info.cemu.Cemu.desktop into PREFIX/share/applications
info.cemu.Cemu.metainfo.xml into PREFIX/share/metainfo
Could you add that into the install step as discussed #20?

@Tachi107
Copy link
Contributor

Re-posting here, as it got lost between all the other comments.

From #1 (comment)

@Zopolis4 I just noticed your CMake PR. I've been working on improving the current state of CMake too, as I'm looking into packaging Cemu for Debian and Ubuntu (as in creating a distro-provided package, not what's currently available here).

Are you working on packaging too?

@Zopolis4 Zopolis4 marked this pull request as ready for review August 30, 2022 01:46
@Zopolis4
Copy link
Contributor Author

The fmt stuff is a bit ugly, and will not work when not using vcpkg unless you decide to install version 7.0.2 manually, but that's about as easy as manually installing 7.0.x, which you needed to do anyways. It only needs to exist until we update to 9.x, anyways.

@Tachi107
Copy link
Contributor

The fmt stuff is a bit ugly, and will not work when not using vcpkg unless you decide to install version 7.0.2 manually, but that's about as easy as manually installing 7.0.x, which you needed to do anyways. It only needs to exist until we update to 9.x, anyways.

Why 7.0.2? Every release on the 7.x branch should work just fine (it works with 7.1.3, for example)

@Tachi107
Copy link
Contributor

Anyway, the diff is huge, could you split the changes in different commits, where each one contains a single logical change, so that this is easier to review?

@Zopolis4
Copy link
Contributor Author

Most of the diff is just from listing the files, the amount of intellectual changes is pretty low.

@Zopolis4 Zopolis4 closed this Sep 7, 2022
@Zopolis4
Copy link
Contributor Author

Zopolis4 commented Sep 7, 2022

Closing in favour of a series of smaller PRs.

deReeperJosh pushed a commit to deReeperJosh/Cemu that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants