Skip to content

Update Adventure mappers #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
joshuasing opened this issue Jan 12, 2023 · 0 comments · Fixed by #187
Closed
1 task done

Update Adventure mappers #186

joshuasing opened this issue Jan 12, 2023 · 0 comments · Fixed by #187
Labels
status: in progress This is being actively worked on type: enhancement This is a feature request or a pull request that adds a feature

Comments

@joshuasing
Copy link
Member

Confirmation

  • I have checked for similar issues.

Problem

The current Adventure mappers do not support the latest version and should be generally improved.

Suggested solution

The existing mappers should be completely replaced with a new, more efficient, and non-static system.

Additional information

No response
@joshuasing joshuasing added type: enhancement This is a feature request or a pull request that adds a feature status: triage This issue is awaiting review status: in progress This is being actively worked on and removed status: triage This issue is awaiting review labels Jan 12, 2023
@joshuasing joshuasing mentioned this issue Jan 13, 2023
Merged
5 tasks
joshuasing added a commit that referenced this issue Jan 16, 2023
@joshuasing
fix: v0.13.0-SNAPSHOT (#187)
ad0ab0b 
 * Separate publish and release workflow from gradle workflow.
 * Switch to `ncipollo/release-action@v1` for creating releases in publish workflow.
 * Update README.md with more information on platforms.
 * Reformat README.md.
 * annotations: Remove `Plugin.Platform`.
 * annotations: Rename `@PlatformDependeny` to `@Dependency`.
 * annotations: Fix bugs in generated main classes
 * Rewrite some Javadoc to make it easier to read.
 * Replace `PluginData` with `ChameleonPluginData` which has builders.
 * Rename plural packages to singular for consistency (users -> user, logging -> logger, etc.).
 * Add Preconditions to aid in checking states and validating arguments.
 * Rewrite Adventure mappers and audience reflection to adapt to Adventure changes and remove static use to avoid problems. (resolves #186)
 * Use `Collection` instead of `List` or `Set` in return types.
 * Add `EventSubscriber.Builder#filters(Collection)`.
 * Create `ServerEvent`.
 * Create `ConsoleUser`to represent platform consoles.
 * Add `Platform.<type>` constants, e.g. `Platform.BUKKIT -> "Bukkit"`.
 * Make PlatformTarget extend Predicate and a functional interface.
 * Add `PlatformTarget.<type>()` methods to match platforms by id, e.g. `PlatformTarget.bukkit()`.
 * Rename `ProxyUser#getServer()` to `ProxyUser#getConnectedServer()` for clarity.
 * Remove `User#chat(String)` and `User#chat(Component)` due to changes in Minecraft 1.19.1+.
 * Make `User` implement `net.kyori.adventure.identity.Identified`.
 * Rename `UserManager#getPlayers()` to `UserManager#getUsers()` for consistency.
 * Rename `UserManager#getPlayer(UUID)` to `UserManager#getUserById(UUID)` for consistency.
 * Add tests with 100% coverage for all Adventure mappers.
 * Add tests with 87% coverage for all Adventure audience reflection classes.
 * Improve format of `libs.versions.toml`.
 * Update adventure-platform to v4.2.0.
 * Update velocity-api to v3.3.1.
 * Update minestom to git:f291437ada.
 * Update annotations to v24.0.0.
 * Update errorprone to v2.18.0.
 * Update junit to v5.9.2.
 * Update nullaway to v0.10.8.
 * Improve nullaway configuration.
 * Add Codecov configuration and uploader.
 * Improve example project a little bit.
 * General reformatting and other improvements.
 * Bump version to `0.13.0-SNAPSHOT`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: in progress This is being actively worked on type: enhancement This is a feature request or a pull request that adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rewrite Adventure mappers, add codecov, other improvements chameleonframework/chameleon
1 participant
@joshuasing