Skip to content

feat: add metadata, user caching, improve event dispatch #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 3, 2023

Conversation

joshuasing
Copy link
Member

@joshuasing joshuasing commented Sep 20, 2023

Summary
Add user metadata system, add user caching, improve event dispatch, improve audience provider.

Fixes #216

Changes

  • Add user metadata system (fix Metadata System #216)
  • Add user caching
  • Improve event dispatch
  • Improve audience provider

Checklist

@joshuasing joshuasing added this to the v0.19.0 milestone Sep 20, 2023
@joshuasing joshuasing added type: feature This adds a new feature type: refactor This refactors existing code type: performance area: api size: XL labels Sep 20, 2023
@joshuasing joshuasing self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #290 (7e6e0f0) into main (d21f5df) will increase coverage by 1.95%.
The diff coverage is 92.35%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #290      +/-   ##
============================================
+ Coverage     70.85%   72.80%   +1.95%     
- Complexity      405      500      +95     
============================================
  Files            72       83      +11     
  Lines          1513     1688     +175     
  Branches         87      106      +19     
============================================
+ Hits           1072     1229     +157     
- Misses          407      425      +18     
  Partials         34       34              
Files Coverage Δ
...in/java/dev/hypera/chameleon/meta/MetadataKey.java 100.00% <100.00%> (ø)
...ava/dev/hypera/chameleon/meta/MetadataKeyImpl.java 100.00% <100.00%> (ø)
...v/hypera/chameleon/platform/PlatformChameleon.java 0.00% <ø> (ø)
...n/platform/adventure/PlatformAudienceProvider.java 100.00% <100.00%> (ø)
...platform/adventure/StandaloneAudienceProvider.java 100.00% <100.00%> (ø)
...meleon/platform/event/PlatformEventDispatcher.java 100.00% <100.00%> (ø)
...pera/chameleon/platform/user/PlatformChatUser.java 100.00% <100.00%> (ø)
...v/hypera/chameleon/platform/user/PlatformUser.java 100.00% <100.00%> (ø)
...a/chameleon/platform/user/PlatformUserManager.java 100.00% <100.00%> (ø)
...era/chameleon/platform/util/PlatformEventUtil.java 0.00% <ø> (ø)
... and 4 more

@joshuasing joshuasing marked this pull request as ready for review September 22, 2023 08:49
@joshuasing joshuasing force-pushed the feat/user-metadata branch 2 times, most recently from 63fe47f to d632297 Compare September 27, 2023 11:59
Copy link
Member

@LooFifteen LooFifteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a load of listeners don't ever get unregistered, which could cause problems when people are using plugins like Plugman. We should be handling support for these kind of plugins because the end user of Chameleon does not have the option to.

@joshuasing joshuasing requested a review from LooFifteen October 3, 2023 08:04
@joshuasing joshuasing merged commit f3cf347 into main Oct 3, 2023
@joshuasing joshuasing deleted the feat/user-metadata branch December 6, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api size: XL type: feature This adds a new feature type: performance type: refactor This refactors existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata System
2 participants