-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add metadata, user caching, improve event dispatch #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
============================================
+ Coverage 70.85% 72.80% +1.95%
- Complexity 405 500 +95
============================================
Files 72 83 +11
Lines 1513 1688 +175
Branches 87 106 +19
============================================
+ Hits 1072 1229 +157
- Misses 407 425 +18
Partials 34 34
|
63fe47f
to
d632297
Compare
d632297
to
abf392c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a load of listeners don't ever get unregistered, which could cause problems when people are using plugins like Plugman. We should be handling support for these kind of plugins because the end user of Chameleon does not have the option to.
api/src/test/java/dev/hypera/chameleon/util/PreconditionsTests.java
Outdated
Show resolved
Hide resolved
...i/src/test/java/dev/hypera/chameleon/platform/adventure/StandaloneAudienceProviderTests.java
Outdated
Show resolved
Hide resolved
...ecord/src/main/java/dev/hypera/chameleon/platform/bungeecord/user/BungeeCordUserManager.java
Outdated
Show resolved
Hide resolved
...m-nukkit/src/main/java/dev/hypera/chameleon/platform/nukkit/event/NukkitEventDispatcher.java
Show resolved
Hide resolved
platform-sponge/src/main/java/dev/hypera/chameleon/platform/sponge/user/SpongeUserManager.java
Outdated
Show resolved
Hide resolved
abf392c
to
ee5b0c1
Compare
Summary
Add user metadata system, add user caching, improve event dispatch, improve audience provider.
Fixes #216
Changes
Checklist