chatmaild: allow echobot to receive unencrypted messages by default #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is mostly useful to test whether a specific server is responsive; for actual users it is less useful. But some operators know about it and use it every once in a while as part of a quick health check, me included. |
hpk42
reviewed
Apr 11, 2025
| @@ -58,7 +58,8 @@ def set_password(self, enc_password): | |||
| if not self.addr.startswith("echo@"): | |||
| logging.error(f"could not write password for: {self.addr}") | |||
| raise | |||
| self.enforce_E2EE_path.touch() | |||
| if not self.addr.startswith("echo@"): | |||
| self.enforce_E2EE_path.touch() | |||
There was a problem hiding this comment.
would rather do this in echo-bot setup (chatmaild/echo.py) not in this generaly code path
There was a problem hiding this comment.
echo.py is run by the echobot user, which doesn't have write permission in this path... we could do stuff with setfacl I guess, as this is anyway installed to get echobot running, but that sounds overly complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up for #535 and #538