Skip to content

(chocolatey-core.extension) Changed key to be single value #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AdmiringWorm
Copy link
Member

This is a compatibility fix to make the function
compatible with Powershell V2. Without this fix
the 'UninstallString'/'InstallLocation' value
will always be null.

This is a compatibility fix to make the function
compatible with Powershell V2. Without this fix
the 'UninstallString'/'InstallLocation' value
will always be null.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@majkinetor
Copy link
Contributor

This is not correct due to the fact that current code has a branch that will never get executed now.

@AdmiringWorm
Copy link
Member Author

I'm not sure I follow, how is this not correct?

Basically the only difference is that there won't be an array available, if no key is found the result would be null so it continues the execution further down the list.

I did see I missed something regarding the verbose output of the # of keys found, but other than that...

Of course, I could change it to iterate through all matches, which is something I considered first.

@majkinetor
Copy link
Contributor

I'm not sure I follow, how is this not correct?

Sorry, my mistake, its OK.

@AdmiringWorm
Copy link
Member Author

@majkinetor I've been thinking since my last comment.

Perhaps iterating through the entire list would be more appropriate?
And exit when the first valid path is found?
Thoughts?

@stale
Copy link

stale bot commented Jun 22, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 22, 2019

Dear contributor,
because this issue seems to be inactive for quite some time now, I've automatically closed it. If you still feel this is a valid issue, please feel free to re-open the issue. Thank you for your contribution.

@stale stale bot closed this Jul 22, 2019
@AdmiringWorm AdmiringWorm deleted the compatibility-fix branch March 21, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants