Skip to content

(GH-70) Implemented validation for tags being supplied #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2019
Merged

(GH-70) Implemented validation for tags being supplied #170

merged 3 commits into from
Mar 9, 2019

Conversation

AdmiringWorm
Copy link
Member

Description

Added new rule for validating that the tag element is specified, and it isn't completely empty.

Related Issue

#70

Motivation and Context

How Has This Been Tested?

Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 105f5cc into chocolatey-community:develop Mar 9, 2019
@gep13
Copy link
Member

gep13 commented Mar 9, 2019

@AdmiringWorm your changes have been merged, thanks for your contribution 👍

@AdmiringWorm AdmiringWorm deleted the feature/tags-not-empty branch March 9, 2019 18:23
gep13 pushed a commit that referenced this pull request Mar 9, 2019
Merge pull request #170 from AdmiringWorm/feature/tags-not-empty

(GH-70) Implemented validation for tags being supplied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants