Skip to content

(GH-70) Implemented validation for id with underscore rule #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2019
Merged

(GH-70) Implemented validation for id with underscore rule #175

merged 2 commits into from
Mar 12, 2019

Conversation

AdmiringWorm
Copy link
Member

Description

Implements the rule to check if the package id contains an underscore.

Related Issue

#70

Motivation and Context

How Has This Been Tested?

Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AdmiringWorm AdmiringWorm changed the title Feature/id underscore (GH-70) Implemented validation for id with underscore rule Mar 10, 2019
gep13
gep13 approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will tidy up the DocumentationUrl in a follow up commit.

@gep13 gep13 merged commit 89d62db into chocolatey-community:develop Mar 12, 2019
gep13 pushed a commit that referenced this pull request Mar 12, 2019
@web-flow
AppVeyor Publish: 89d62db
534a82f 
Merge pull request #175 from AdmiringWorm/feature/id-underscore

(GH-70) Implemented validation for id with underscore rule
@AdmiringWorm AdmiringWorm deleted the feature/id-underscore branch March 13, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdmiringWorm @gep13