You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We'll actually enable it after the main RN v0.61 -> v0.62 upgrade
commit, if only because running Flipper pre-RN v0.62 isn't
advertised as something you can do. Enabling it means calling the
initialize function, like in facebook/react-native@05f5cb534, but in
the form it took in facebook/react-native@b4d1fcfb2 (and in the
conditional that appears there).
This encompasses several RN commits, as follows, some of which broke
builds (which poses a problem even without Flipper enabled). We lump
these in with their fixes, so that we don't knowingly introduce
errors at any commit in our project. Some of these problems can be
traced to upgrading the FlipperKit pod and not handling breaking
changes at the same time. Perhaps it wouldn't have been easy for RN
to catch these before merging.
Generally, though, the RN commits aren't very clear or coherent (at
least by our standards), so I feel safer flattening all of these
even if something could plausibly stand alone in our project.
----- facebook/react-native@70274f4e9 -----
This commit is unstable. One reason is that `pod install` fails
until `:modular_headers` is added to the `Yoga` pod declaration in
facebook/react-native@898b1db6d. The failure message:
```
[!] The following Swift pods cannot yet be integrated as static
libraries:
The Swift pod `YogaKit` depends upon `Yoga`, which does not define
modules. To opt into those targets generating module maps (which is
necessary to import them from Swift when building as static
libraries), you may set `use_modular_headers!` globally in your
Podfile, or specify `:modular_headers => true` for particular
dependencies.
```
----- facebook/react-native@e8541e03f -----
The claim is that this commit adds running React Dev Tools to the
template. I had thought this was something totally separate from
Flipper (and so this would naturally stand in its own commit), but
no; the added code comes from the `FlipperKitReactPlugin` subspec of
the `FlipperKit` pod, and it'll be invoked in the Flipper
initialization function.
This commit also advances the FlipperKit pod version to v0.23.6; I'm
not aware of any new issues that were specifically introduced in
this version.
Still, seems safest to apply these changes in this giant commit.
----- facebook/react-native@898b1db6d -----
A small handful of changes in `AppDelegate.m`, the Podfile, and
`project.pbxproj` are made here.
The motivation for the `AppDelegate.m` changes isn't clear to me,
unless it's "The integration of Flipper on iOS was crashing the
template"--not super descriptive or helpful in finding the origin of
the issue.
In the Podfile, the addition of `:modular_headers => true` to the
`Yoga` pod declaration fixes a `pod install` failure introduced in
facebook/react-native@70274f4e9, described above.
Also in the Podfile, the change of FlipperKit's version to v0.30.0
introduces a build failure associated with
facebook/flipper@ab121f9d9 (Flipper release tag v0.26.0); see
facebook/react-native#27565 (comment).
That issue was non-optimally resolved in
facebook/react-native@b4d1fcfb2, which we take for now in this
commit (see below); a more principled solution is open as
facebook/flipper#1171.
The `project.pbxproj` changes here aren't fully explained, but
here's what I think happened, and what I did about it:
- An empty Swift file was added, to rouse Xcode into being prepared
to handle Swift files, which is needed for the "YogaKit" dep; see
facebook/react-native#27426 (comment).
This step is included in the upgrade guide [1]. The empty Swift
file was later backed out in facebook/react-native@e3218a0d9 (see
below), which is why it doesn't appear here.
- The addition of the empty Swift file activated a wizard that
walked the user through setting up an Objective-C "bridging
header" file and set some plausibly desired settings in the
`project.pbxproj` file. RN deleted the bridging header file, but
the settings remained.
We had actually already set up a bridging header file a long time
ago, in d38129b, and this setup wizard didn't activate when I
created the empty Swift file. I tried to *get* it to activate (to
better reproduce the settings changes) by deleting our bridging
header file and re-adding the Swift file, but the wizard didn't
activate. However, the settings that got added in d38129b seem
to match these settings pretty closely; one notable difference is
that a SWIFT_VERSION build setting is 4.2 instead of 5.0.
In any case, the upgrade guide on the Xcode changes [1] only says
the bridging-header wizard will "most likely" appear, and if it
doesn't, just keep going.
- They added "English" under `knownRegions` in the project info. It
appears Xcode doesn't like this change; it gets reverted later as
part of facebook/react-native@ebb629d05 (which we take elsewhere
in this series, before the upgrade, as an instance of zulip#4112), when
they follow an Xcode automatic deprecation fix. So, ignore this.
----- facebook/react-native@e3218a0d9 -----
This Facebook commit looks fairly coherent, but it's a partial
reversion of facebook/react-native@898b1db6d (just above) with a
tweak on top of it. So, might as well put it into the same commit.
The `project.pbxproj` changes are as follows, as best as I can tell:
- The empty Swift file described just above is removed. The commit
message makes it sound like it's no longer necessary for projects
to make the Swift file in the first place; on the other hand, the
upgrade guide on the Xcode changes [1] indicate that it should be
created and then removed.
- A `LIBRARY_SEARCH_PATHS` setting is added. This *is* reflected in
the upgrade guide on the Xcode changes [1]; following those
instructions does indeed generate a portion of the diff.
- An `LD_RUNPATH_SEARCH_PATHS` setting is added; this is *not*
reflected in the upgrade guide. It's reportedly crucial; see
facebook/react-native#27922 (comment).
I copied the code.
- A `DEAD_CODE_STRIPPING` setting is removed; this is *not*
reflected in the upgrade guide. Reportedly (and in my experience,
as best as I can remember and conclude), it's crucial; see
facebook/react-native#27922 (comment).
I copied the code.
----- facebook/react-native@8f954b365 -----
Just simple prose adjustments to a comment, but it's substantially
reworked in facebook/react-native@b4d1fcfb2 (which follows).
----- facebook/react-native@b4d1fcfb2 -----
This looks like a partial reversion of
facebook/react-native@898b1db6d (above), with a tweak; the
`FB_SONARKIT_ENABLED` conditional is removed from `AppDelegate.m`,
but that identifier now appears in the `project.pbxproj`.
`ENABLE_BITCODE = NO;` is added to the `project.pbxproj` to fix an
issue introduced in facebook/react-native@898b1db6d (see above); see
facebook/react-native#27565 (comment).
The issue would be better resolved with something like
facebook/flipper#1171. In particular, I'm inclined to agree with
that PR's author, who says "it strikes me that not having access to
current (and possible future) updates of a cryptography library is
not a good long-term plan".
This commit also continues the advancement of the FlipperKit pod's
version, this time to v0.30.2, and adjusts some comments.
----- facebook/react-native@f6a8452e7 -----
After an upgrade to FlipperKit v0.32.0 in
facebook/react-native@ada73a354, quickly reverted in
facebook/react-native@4bb17944f, this commit brings us to v0.33.1.
----- facebook/react-native@8858d879e -----
This is the last commit that affects Flipper on iOS before the v0.62
release was made. It doesn't continue the advancement of the
FlipperKit version (and a good thing, too, maybe!). It lists several
transitive dependencies of FlipperKit pods to the Podfile and gives
them each a `:configuration => 'Debug'` setting, and that's it.
It appears to be accounting for a CocoaPods quirk that means that,
before this change is made, all those dependencies would get
included in release builds, increasing the binary size. Might as
well avoid having any commits with that increased size; so, conclude
this giant commit with these changes.
All that's left is to actually enable Flipper, which we'll do after
the main upgrade commit; see
zulip#4244 (comment).
[1] react-native-community/upgrade-support#13
0 commit comments