-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[CLN]: remove offset ID atomic from record segment reader #3371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This was referenced Dec 30, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
1e493ab
to
ad6e0db
Compare
54af109
to
f3e0ec9
Compare
3b1a65f
to
a37ca15
Compare
f3e0ec9
to
1d2273f
Compare
a37ca15
to
8ff398b
Compare
1d2273f
to
4635765
Compare
HammadB
approved these changes
Jan 6, 2025
4635765
to
1e8291e
Compare
34de5a2
to
d165237
Compare
1e8291e
to
497d5b1
Compare
497d5b1
to
f4d4bcc
Compare
d165237
to
e916633
Compare
f4d4bcc
to
195f7f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Small cleanup to clarify usage of offset ID on reader.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a