[ENH]: add distributed impl for ListDatabases #3440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
codetheweb
force-pushed
the
feat-list-databases-api-distributed
branch
3 times, most recently
from
6b01b0b to
f35dd9a
Compare
1 task
codetheweb
force-pushed
the
feat-list-databases-api
branch
from
ff322a0 to
37701ee
Compare
codetheweb
force-pushed
the
feat-list-databases-api-distributed
branch
from
f35dd9a to
503c805
Compare
1 task
codetheweb
force-pushed
the
feat-list-databases-api
branch
from
f2fc604 to
b9bdfe2
Compare
1 task
codetheweb
force-pushed
the
feat-list-databases-api-distributed
branch
from
503c805 to
e7ae25d
Compare
codetheweb
force-pushed
the
feat-list-databases-api
branch
from
b9bdfe2 to
8b3a2e8
Compare
codetheweb
force-pushed
the
feat-list-databases-api-distributed
branch
from
e7ae25d to
f892fc4
Compare
codetheweb
changed the base branch from
feat-list-databases-api
to
graphite-base/3440
codetheweb
added a commit
that referenced
this pull request
Jan 10, 2025
## Description of changes Adds a method to the admin client to list all databases for a tenant. Has limit/offset parameters similar to how listing collections works. The implementation for distributed Chroma is in a separate PR, next in this stack: #3440. See chroma-core/hosted-chroma#900 for main tracking issue. ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* Updated.
codetheweb
force-pushed
the
graphite-base/3440
branch
from
8b3a2e8 to
457f855
Compare
codetheweb
force-pushed
the
feat-list-databases-api-distributed
branch
from
f892fc4 to
143f6b0
Compare
codetheweb
force-pushed
the
feat-list-databases-api-distributed
branch
from
143f6b0 to
98e57de
Compare
sanketkedia
reviewed
Jan 10, 2025
sanketkedia
approved these changes
Jan 10, 2025
codetheweb
force-pushed
the
feat-list-databases-api-distributed
branch
from
98e57de to
4b233ff
Compare
codetheweb
force-pushed
the
feat-list-databases-api-distributed
branch
from
4b233ff to
625e4e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds support to distributed Chroma for the new list databases API.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustCovered by existing test introduced in the PR below in the stack.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a