Skip to content

[ENH] Use node name for routing #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 15, 2025
Merged

[ENH] Use node name for routing #3452

merged 5 commits into from
Jan 15, 2025

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jan 9, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This allows the FE to route based on the node name instead of the id
    • It introduces config to control the routing mode. For single-node envs, like local tests, we still want ip based routing
    • We only route to nodes if ALL entries in memberlist have nodes populated
    • This change is backwards compatible, with the exception of multiple frontends maybe having different routing schemes during rollout. This is tolerable.
  • New functionality
    • None

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

github-actions bot commented Jan 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

github-actions bot commented Jan 9, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@HammadB HammadB changed the base branch from main to hammad/add_node_name_to_memberlist January 9, 2025 02:48
Copy link
Collaborator Author

HammadB commented Jan 9, 2025

@HammadB HammadB force-pushed the hammad/add_node_name_to_memberlist branch from 0034684 to a4c36bf Compare January 9, 2025 20:42
@HammadB HammadB force-pushed the hammad/use_name_for_routing branch from 4b047d7 to 177103a Compare January 9, 2025 20:42
Copy link

github-actions bot commented Jan 9, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@HammadB HammadB changed the title Use node name for routing [ENH] Use node name for routing Jan 13, 2025
@HammadB HammadB force-pushed the hammad/add_node_name_to_memberlist branch from 33ec286 to ffe7864 Compare January 14, 2025 00:42
@HammadB HammadB force-pushed the hammad/use_name_for_routing branch from 177103a to f6a5af6 Compare January 14, 2025 00:44
@HammadB HammadB marked this pull request as ready for review January 14, 2025 00:44
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@HammadB HammadB force-pushed the hammad/add_node_name_to_memberlist branch from ffe7864 to 0bc4344 Compare January 15, 2025 01:28
@HammadB HammadB force-pushed the hammad/use_name_for_routing branch from 30d3e2b to 7ffc4f4 Compare January 15, 2025 01:32
@HammadB HammadB force-pushed the hammad/use_name_for_routing branch from 7ffc4f4 to 123c15a Compare January 15, 2025 01:41
@HammadB HammadB changed the base branch from hammad/add_node_name_to_memberlist to main January 15, 2025 01:41
@HammadB HammadB merged commit 276fef8 into main Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants